Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MIP-1 Status from Draft to Review #15

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

vandan
Copy link
Collaborator

@vandan vandan commented Jun 29, 2023

Also updated the Motivation section to highlight some additional reasons why using wallet_watchAsset for NFTs would be beneficial to dapp developers.

Also updated the Motivation section to highlight some additional reasons why using wallet_watchAsset for NFTs would be beneficial to dapp developers.
removed the step that was auto-generating the node_modules dir
Also adding a .gitignore for any future needs.
@vandan vandan requested a review from adonesky1 June 29, 2023 22:25
MIPs/mip-1.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Donesky <[email protected]>
Copy link
Collaborator

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 merged commit 65cf9f4 into main Jun 30, 2023
1 check passed
@vandan vandan deleted the vandan-review-prep branch June 30, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants